Skip to content

core: Resolve Rust 1.88 clippy lints and format strings#6933

Merged
steviez merged 6 commits intoanza-xyz:masterfrom
steviez:rust_v1.88_clippy_core
Jul 14, 2025
Merged

core: Resolve Rust 1.88 clippy lints and format strings#6933
steviez merged 6 commits intoanza-xyz:masterfrom
steviez:rust_v1.88_clippy_core

Conversation

@steviez
Copy link
Copy Markdown

@steviez steviez commented Jul 11, 2025

Problem

Working towards #6850, broken out from #6854

Summary of Changes

Three commits:

  • Add #[rustfmt::skip] markup to several strings that were manually crafted for readability
  • Run cargo clippy --fix --tests with Rust 1.88.0 set in rust-toolchain.toml
  • Run cargo fmt with format_strings = true set in rustfmt.toml

Comment thread core/tests/scheduler_cost_adjustment.rs Outdated
Comment thread core/src/replay_stage.rs
Comment on lines -2645 to +2622
for slot: {} tracked by tower. This indicates a bug in the on chain adoption logic",
for slot: {} tracked by tower. This indicates a bug in the on chain adoption \
logic",
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar here - maybe this one didn't get picked up since one of the args is a function call ?

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jul 11, 2025

Codecov Report

Attention: Patch coverage is 48.98990% with 101 lines in your changes missing coverage. Please review.

Project coverage is 83.3%. Comparing base (e1bc44e) to head (0c14cae).
Report is 16 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #6933     +/-   ##
=========================================
- Coverage    83.3%    83.3%   -0.1%     
=========================================
  Files         853      853             
  Lines      377846   377843      -3     
=========================================
- Hits       314760   314748     -12     
- Misses      63086    63095      +9     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread core/benches/receive_and_buffer_utils.rs Outdated
Comment thread core/src/replay_stage.rs Outdated
@steviez steviez requested a review from brooksprumo July 14, 2025 05:37
Copy link
Copy Markdown

@brooksprumo brooksprumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@steviez steviez merged commit 3d03f5e into anza-xyz:master Jul 14, 2025
41 checks passed
@steviez steviez deleted the rust_v1.88_clippy_core branch July 14, 2025 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants